Started his football career with local clubs Burslem Park Boys and Smallthorne before he was invited to join Port Vale in 1906, where he played 11 games, scoring one goal, until Port Vale lost their league status and then signed for Stoke and made one appearance before they withdrew from the league.
One of a large number of players Tottenham, who replaced Stoke in Division 2 in July 1908, had to sign to ready themselves for League football, Brough played only one game each in the league and FA Cup at half back before going back to the Valiants in 1909.
Moved onto Liverpool and Bristol City before going back to Vale Park for a third spell from 1913 to 1922. Played 61 more games for Port Vale and notched five goals before retiring..